Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defines BOOST_SYSTEM_NO_DEPRECATED. #146

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

tdd11235813
Copy link
Contributor

@tdd11235813 tdd11235813 commented Jun 21, 2019

Copy link
Contributor

@psteinb psteinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tdd11235813
Copy link
Contributor Author

ah do not merge, I want to add a version check, since 1.66.0+ no more uses this definition.

- fixes boost::system::throws multiple definition issue in mpicbg-scicomp#145
@tdd11235813
Copy link
Contributor Author

ok, I've put the thing into the types.hpp now. Idea is to reduce cmake dependencies in the future to be able to provide a cmake-less version of gearshifft.
You can merge now if you like it.

@psteinb
Copy link
Contributor

psteinb commented Jun 21, 2019

did you check more recent boost versions?

@tdd11235813
Copy link
Contributor Author

1.65.1, 1.66.0, 1.68.0 and now also 1.70.0.

@psteinb psteinb merged commit a21c6f8 into mpicbg-scicomp:master Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants