build: bump minimal Windows version to 10 and remove not neede compatibility code #14320
Conversation
|
Download the artifacts for this pull request: |
| // https://docs.microsoft.com/en-us/windows/console/setconsolemode | ||
| // These values are effective on Windows 10 build 16257 (August 2017) or later | ||
| #ifndef ENABLE_VIRTUAL_TERMINAL_PROCESSING | ||
| #define ENABLE_VIRTUAL_TERMINAL_PROCESSING 0x0004 | ||
| #endif | ||
| #ifndef DISABLE_NEWLINE_AUTO_RETURN | ||
| #define DISABLE_NEWLINE_AUTO_RETURN 0x0008 | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Out of curiosity, are Windows 10 builds prior to 16257 unsupported?
There was a problem hiding this comment.
22H2, will be the final version of Windows 10
https://learn.microsoft.com/en-us/lifecycle/products/windows-10-home-and-pro
Any other version than Windows 10 19045 are unsupported.
There was a problem hiding this comment.
Those are only compile time definitions, it doesn't matter for runtime support at all. Any Windows 10 is supported.
There was a problem hiding this comment.
Any Windows 10 is supported.
GetSystemMetricsForDpi is only present on 1607/14393 and later, so 10240 isn't supported even though it's still officially supported until October 14, 2025.
Even though 10240 is not an important version (doesn't have a Windows Server release) it still needs to be clarified in the system requirements.
There was a problem hiding this comment.
GetSystemMetricsForDpi is only present on 1607/14393 and later, so 10240 isn't supported even though it's still officially supported until October 14, 2025.
Good point, I can add a note to the readme, but frankly, I don't care that much about those. It would be really surprising to me that someone managed to not update it, given how update cycle works on Windows. There were 3 more LTSC versions and only the latest one has mainstream support.
Not necessary looking to merge this yet, just for tracking what is no longer needed.