Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

playlist: fix some playlist-prev/playlist-next edge cases #14387

Merged
merged 2 commits into from
Jun 25, 2024
Merged

playlist: fix some playlist-prev/playlist-next edge cases #14387

merged 2 commits into from
Jun 25, 2024

Commits on Jun 19, 2024

  1. playlist: let playlist-prev go to last item in playlist 

    Previously, playlist-prev didn't work if you played a playlist to
completion using --idle and tried to go back. Naturally, one would
expect this to bring up the last item in the playlist, but nothing
happens. This is just because playlist_get_next is stupid and doesn't
take this into account since pl->current is NULL and thus returns NULL.
Fix this by considering the direction, checking if the playlist was
played to completion and grabbing the last entry in the index.
    @Dudemanguy
    Dudemanguy committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    c28006a View commit details
    Browse the repository at this point in the history

  2. playlist: let playlist-next go to first item if player is idle 

    Similar to the previous commit but the other way around. If you start
mpv as idle, load up a playlist without immediately hitting play and
then try to go to the next item, nothing happens. Naturally, you would
expect this to go to the first item. Fix this detecting if the playlist
has not started yet, the direction, and going to the first item in the
list.
    @Dudemanguy
    Dudemanguy committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    1fa03c0 View commit details
    Browse the repository at this point in the history