remove custom messages for deprecated/removed options #14396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
kasper93
approved these changes
Jun 24, 2024
Tell users to see interface-changes instead which has more detailed informaion. No point to keep this pointless printing around.
kasper93
reviewed
Jun 25, 2024
Pointless. Use interface-changes instead.
Dudemanguy
reviewed
Jun 25, 2024
Comment on lines
+751
to
+752
| MP_ERR(config, "This option might have been renamed, removed, or changed semantics.\n" | ||
| "See DOCS/interface-changes.rst for possible replacements.\n"); |
There was a problem hiding this comment.
Is this really necessary? Seems noisy.
There was a problem hiding this comment.
I don't think it's noisy. I will consider changing it if several users complain about this.
Dudemanguy
approved these changes
Jun 25, 2024
N-R-K
reviewed
Jun 27, 2024
| {"gamut-warning", OPT_REMOVED("Replaced by --gamut-mapping-mode=warn")}, | ||
| {"gamut-clipping", OPT_REMOVED("Replaced by --gamut-mapping-mode=desaturate")}, | ||
| {"tone-mapping-desaturate", OPT_REMOVED("Replaced by --tone-mapping-mode")}, | ||
| {"tone-mapping-desaturate-exponent", OPT_REMOVED("Replaced by --tone-mapping-mode")}, |
There was a problem hiding this comment.
I don't see how having to scour through interface-changes.rst is more helpful than this.
I'm also having a hard time seeing what the purpose of this even is. Just removing code for the sake of it?
There was a problem hiding this comment.
Please refer to #14382 for the discussion. I believe everything has been said and should give you idea, why this PR exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This warning system isn't used in any meaningful way and the messages are pointless when
DOCS/interface-changes.rsthas more detailed and helpful information, so just remove them and tell users to seeDOCS/interface-changes.rstinstead.