Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadfile: update the format of terminal track information #14405

Merged
merged 1 commit into from
Jun 24, 2024

Commits on Jun 24, 2024

  1. loadfile: update the format of terminal track information

    Stop making unselected tracks and editions grey because they can be hard
    to read over a dark background (\033[2m would be hard to differentiate
    from regular text with a light theme instead), and because there is no
    way to not print the escape sequences in --log-file.
    
    Just use the same circles as the OSD and OSC. We need to print the empty
    circles for alignment on mlterm with East Asian fonts (we could also
    make them invisible with \033[8m but it would still get added to log
    files).
    
    Add back the space before tracks and editions when printed after
    "Playing..." or "Track switched" and similar, so they look like a
    sub-section of it, consistently with the metadata which starts with
    space which makes it look like a sub-section of the "File tags" line.
    
    Leave 2 spaces between track columns.
    
    Make the lang options only as long as the longest language.
    
    Place hls-bitrate within the same parentheses as the other data.
    
    Replace the incomprehensible (*) (f) and [P] with textual descriptions
    within []. Also place external there.
    
    Stop converting Hz to kHz for consistency with other log messages, e.g.
    AO: [pipewire] 48000Hz stereo 2ch floatp
    
    Remove the space in "2 ch" so it doesn't look like 2 separate values (We
    considered using mp_chmap_to_str(&s->codec->channels) but it prints
    values like "unknown2").
    guidocella committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    d5b0d00 View commit details
    Browse the repository at this point in the history