audio/out: add libmpv callback driver #16769
Conversation
OrionMoonclaw
force-pushed
the
ao_libmpv
branch
from
f5adaf1 to
04c5398
Compare
| static bool set_pause(struct ao *ao, bool paused) | ||
| { | ||
| return true; // signal support so common code doesn't write silence | ||
| } |
There was a problem hiding this comment.
so the client is not informed of a pause situation?
| ao->bps = ao->channels.num * (int64_t)ao->samplerate * af_fmt_to_bytes(ao->format); | ||
|
|
||
| MP_INFO(ao, "libmpv: Samplerate: %d Hz Channels: %d Format: %s\n", | ||
| ao->samplerate, ao->channels.num, af_fmt_to_str(ao->format)); |
There was a problem hiding this comment.
how does the client find out which format the blob of data he gets is, anyway?
There was a problem hiding this comment.
the audio current audio format can be grabbed as a property, though I suppose I could just pass that in the callback as well
There was a problem hiding this comment.
That's also async, so won't work reliably.
I think it would be more practical if sample rate and channels were set ahead of time and then the driver would only support s16.
There was a problem hiding this comment.
Correct me if I'm wrong, but it's already possible to set the format with this option before mpv initializes, so I think that should cover it. I might just add a note about it in the docs.
Line 669 in 77dee9b
If that's not enough I could also add an option specific to this ao, I'd prefer to keep it configurable since I personally would like the samples as floats, it saves me an extra conversion step.
include/mpv/client.h
Outdated
|
|
||
| /** | ||
| * Set a custom function that should be called on new audio data. Raw PCM is passed in as an argument to the callback. | ||
| * This can only be used with ao set to libmpv and after the audio driver has been initialized. |
There was a problem hiding this comment.
won't this mean that the client will potentially miss the first samples because he has to race against "ao init" until the callback can be set?
There was a problem hiding this comment.
I think registering the callback on MPV_EVENT_AUDIO_RECONFIG should be good enough, but I'll have a look at this later
There was a problem hiding this comment.
Not really, because events are delivered async.
|
Download the artifacts for this pull request: Windows |
|
IMO the libmpv AO initialization should block indefinitely until the client receives If the audio format can be customized, then the callback function should tell the client which format is in use, to avoid possible race conditions in accessing properties. |
OrionMoonclaw
force-pushed
the
ao_libmpv
branch
2 times, most recently
from
9da99e5 to
11c19d4
Compare
|
I marked it as a draft, since it's gonna need a bit more discussion. Right now I made it so the callback can be set before ao init by storing it under MPContext, it feels a bit ugly, but it should work. |
This adds an ao driver that can be used to register a callback with libmpv to get raw PCM data. Useful for embedding mpv in applications such as game engines, which need the audio to be played in a 3D world and spatialized. Signed-off-by: Orion Moonclaw <[email protected]>
OrionMoonclaw
force-pushed
the
ao_libmpv
branch
from
11c19d4 to
d9e3432
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| mpctx, mpctx->encode_lavc_ctx, out_rate, | ||
| out_format, out_channels); | ||
|
|
||
| if (strcmp(mpctx->ao->driver->name, "libmpv") == 0) |
Check failure
Code scanning / ClusterFuzzLite/CIFuzz
Don't crash Error
3 participants
This adds an ao driver that can be used to register a callback with libmpv to get raw PCM data. Useful for embedding mpv in applications such as game engines, which need the audio to be played in a 3D world and spatialized.
This was tested with libmpvbridge (not public yet), which I'm developing to use mpv in Renderite.Godot.
closes #9283