Skip to content

Conversation

guidocella
Copy link
Contributor

While this was funny, gpu-next doesn't support --sharpen and it is now the default VO, so replace it with something that actually works.

@atrxia1
Copy link

atrxia1 commented Oct 11, 2025

May as well update all of the relevant options so that they're appended with "(--vo=gpu only)" or something (--fbo-format, --sigmoid-upscaling, --linear-*scaling, etc.). The manual entry for --tone-mapping-max-boost does this currently.

@github-actions
Copy link

github-actions bot commented Oct 11, 2025

@guidocella
Copy link
Contributor Author

--sigmoid-upscaling, --linear-downscaling and --linear-upscaling do affect gpu-next.

@atrxia1
Copy link

atrxia1 commented Oct 11, 2025

All three of those options do the same thing in gpu-next, so listing them in the manual is misleading without documenting what they actually do in gpu-next. --vo=gpu is the only VO that lets you control them individually without affecting each other.

So even if the mpv team intends to deprecate all three of them in the future in favor of one global "linearize" option, the differences should still be documented, as it's not something the average end-user can intuit themselves.

@guidocella
Copy link
Contributor Author

Yeah it's misleading for sure I meant it's not as simple as --sharpen which actually does nothing. --linear-upscaling even defaults to no when it actually upscales linearly by default. By the way, --linear-downscaling is still broken on monochrome manga and makes them brighter.

etc/mpv.conf Outdated
Comment on lines 143 to 144
#[bright]
#gamma=20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about both?

Suggested change
#[bright]
#gamma=20
#[eye-cancer]
#sharpen=5
#gamma=20

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I don't see why gamma=20 would cause eye cancer. But hopefully in a distant future --sharpen and --vo=gpu will be completely removed so we might as well preemptively remove the --sharpen example so we don't forget to update it.

By the way, before c3299d5 this used vf-add=flip, wm4 probably changed it for hwdec compatibility.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I don't see why gamma=20 would cause eye cancer.

gamma=100 certainly does.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced

gpu-next doesn't support --sharpen and it is now the default VO, so
replace it with something that actually works.
@guidocella guidocella changed the title etc/mpv.conf: replace eye-cancer profile etc/mpv.conf: replace the --sharpen example Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants