-
Notifications
You must be signed in to change notification settings - Fork 3.1k
etc/mpv.conf: replace the --sharpen example #16918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
May as well update all of the relevant options so that they're appended with "(--vo=gpu only)" or something ( |
Download the artifacts for this pull request: Windows |
|
All three of those options do the same thing in gpu-next, so listing them in the manual is misleading without documenting what they actually do in gpu-next. --vo=gpu is the only VO that lets you control them individually without affecting each other. So even if the mpv team intends to deprecate all three of them in the future in favor of one global "linearize" option, the differences should still be documented, as it's not something the average end-user can intuit themselves. |
Yeah it's misleading for sure I meant it's not as simple as |
etc/mpv.conf
Outdated
#[bright] | ||
#gamma=20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about both?
#[bright] | |
#gamma=20 | |
#[eye-cancer] | |
#sharpen=5 | |
#gamma=20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I don't see why gamma=20
would cause eye cancer. But hopefully in a distant future --sharpen
and --vo=gpu
will be completely removed so we might as well preemptively remove the --sharpen
example so we don't forget to update it.
By the way, before c3299d5 this used vf-add=flip
, wm4 probably changed it for hwdec compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I don't see why
gamma=20
would cause eye cancer.
gamma=100
certainly does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced
gpu-next doesn't support --sharpen and it is now the default VO, so replace it with something that actually works.
f2dcd80
to
055c454
Compare
While this was funny, gpu-next doesn't support --sharpen and it is now the default VO, so replace it with something that actually works.