mac/common: fix window position on multi monitor setups #16940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on multi monitor setups the position of the window was wrongly computed when the position was forced, eg the calculated rectangle was screen relative but the function expected absolute coordinates. this is a regression from 50042f5 and mpv-player#15500, where support for --force-window-position was introduced. this worked in simple one monitor setups and in some cases on multi monitor setups by sheer coincidence. calculate the absolute position of the window by taking the screen into account when needed. Fixes mpv-player#16929
Akemi
force-pushed
the
mac_force_window_position
branch
from
8c574e4 to
420a812
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on multi monitor setups the position of the window was wrongly computed when the position was forced, eg the calculated rectangle was screen relative but the function expected absolute coordinates.
this is a regression from 50042f5 and #15500, where support for --force-window-position was introduced. this worked in simple one monitor setups and in some cases on multi monitor setups by sheer coincidence.
calculate the absolute position of the window by taking the screen into account when needed.
Fixes #16929