Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create iSIM package for pip installation #8

Merged
merged 9 commits into from
Oct 4, 2024
Merged

Create iSIM package for pip installation #8

merged 9 commits into from
Oct 4, 2024

Conversation

khuddzu
Copy link
Contributor

@khuddzu khuddzu commented Jun 27, 2024

A setup.py script was created for easy "pip install -e ." command.
In order to do this some modifications needed to be made.
I am reorganizing all isim_*.py code into an iSIM directory. In doing so I removed the isim prefix to all scripts.
All scripts in package are imported through an iSIM import.
I have changed all imports in the .py scripts to be compatible with this. At current I have not changed the ipynb, but will before merging.

@khuddzu
Copy link
Contributor Author

khuddzu commented Jun 28, 2024

I have begun some scripts to establish tests for the code as well. However, I think for organization sake this is better done in its separate pull request. I don't want to merge too much at one time. So we can discuss further in the meeting monday.

@khuddzu khuddzu self-assigned this Jun 28, 2024
Copy link
Member

@ramirandaq ramirandaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kate, there are a couple of conflicts with the base code. Once those are resolved we can merge this.

Reorganize repo to allow for pip installation
@khuddzu khuddzu merged commit 78ba727 into main Oct 4, 2024
@khuddzu khuddzu deleted the add-installer branch October 4, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants