Improve test coverage&prints by actually checking indentation #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi-Angel
force-pushed
the
fix-indent-tests
branch
from
52d00e9
to
63e5879
Compare
|
UPD: fixed commit description |
There's terminology clash: `pcal-mode--statement-end-re` just detects anything ending with semicolon, however the `pcal-mode--statement-begin-re` detects variables specifically. One of them seem to be named incorrectly, let's rename the `statement-begin` to `variables-begin`.
tabs indentation is up to Emacs' indent functions, we don't need to test it. Avoiding tabs in tests simplifies comparing the current indentation and allows to increase test coverage in the next commit.
This commits adds testing of the actual `pcal-mode-indent-line` and `tla-mode-indent-line` functions, rather than some internal getters. As a bonus, this allows us to print the actual line in the tests for the case something fails, which we do as well.
This is similar to
fc1af6d "Let `indent-line-to` decide on (point) location"
It turns out there's two indenation functions, so fix the 2nd one as well.
This unbreaks (newline-and-indent).
Before this commit calling newline-and-indent would put caret at the
beginning of line. This is not what a user wants, because they usually
desire continue typing code on the new line.
So remove the save-excursion call.
While at it, remove the beginning-of-line call as well, because both
are called first thing inside (pcal-mode--indent-column), so as far as
that function concerned having them earlier is unnecessary.
Hi-Angel
force-pushed
the
fix-indent-tests
branch
from
63e5879
to
fc666f9
Compare
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The older code didn't test the public indentation function but instead some getter that the function was using. It also had a minor bug where the ELT's
shouldfunction was givenexp-lineas part of the "actual" parameter.We fix both problems and also do some minor cleanup.
This PR also includes a commit that changes
tla-mode-indent-lineto have code similar to commit fc1af6d for the other indentation function. When I did fc1af6d I didn't know there are two functions for the same functional. Feel free to ask me to send it as a separate PR if you want.