Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overwrite the aws config instead of appending #17

Closed
wants to merge 4 commits into from
Closed

Overwrite the aws config instead of appending #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c9e28f
Overwrite the aws config instead of appending
rdinardi-bw Jun 29, 2021
3a30af6
provide an optional aws_profile option to the action
rdinardi-bw Jun 30, 2021
3fe0ab8
telling the github env where the aws configuration is and setting the…
rdinardi-bw Jun 30, 2021
e9cf5cf
reverting back to overwriting the config and updating the readme
rdinardi-bw Jul 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Obtain temporary AWS Creds from your Okta Profile.
Here's an example. All options are required except `okta_mfa_method` which default to TOTP based notification.

```yaml
- name: Create AWS profile
- name: Get AWS Credentials
uses: mrchief/aws-creds-okta@master # or a tagged release version
with:
aws_role_arn: arn:aws:iam::account-id:role/role-name
Expand All @@ -32,6 +32,7 @@ It also masks the actual values in the logs for added security.
- Currently only supports `totp` authentication. There are plans to add support for other MFA methods. PRs welcome.
- `okta_app_url` can be obtained by right clicking the Okta tile for you AWS account. This setup allows for federated login to different AWS accounts.
- `okta_password` & `okta_mfa_seed` can be set via environment variables `${{ env.OKTA_MFA_SEED }}` although it is not recommended to do so as it can leak secrets. Github repo secrets are the easiest way but if you manage secrets via some other mechanism, you can also use them - these are just normal inputs, you can pass them anything.
- If you run this action multiple times, you will receive new credentials each time, even if you specify the same role arn. This is because we cannot create an aws config or credentials file from the action that is accessible in the workflow. This also means we cannot support profiles.

## Can I use this

Expand Down
2 changes: 1 addition & 1 deletion entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ config="${awsDir}/config"
credentials="${awsDir}/credentials"

mkdir -p "${awsDir}"
echo -e "[profile default]\noutput = json" >>"$config"
echo -e "[profile default]\noutput = json" >"$config"

# Attempt to get aws credentials via tokendito
max_attempts=10
Expand Down