Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add multi-way if #16

Merged
merged 1 commit into from
Dec 5, 2023
Merged

feat: add multi-way if #16

merged 1 commit into from
Dec 5, 2023

Conversation

gregorias
Copy link
Contributor

Description of changes

Adds a multi-way if snippet.

Things done
  • Tested, as applicable:
    • Manually
    • Added tests: No, because I don't see any tests for if-snippets to base new tests on.
  • Updated CHANGELOG.md
    (if applicable).
  • Fits CONTRIBUTING.md

mrcjkb
mrcjkb reviewed Dec 4, 2023
View reviewed changes
Copy link
Owner

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😄

Do you have a screenshot or code block snippet of the result?
I left a suggestion (for the indentation). Not 100 % sure if it's a sensible one.

lua/haskell-snippets/expressions.lua Outdated Show resolved Hide resolved
@gregorias
Copy link
Contributor Author

Do you have a screenshot or code block snippet of the result?

I'll attach one shortly.

I left a suggestion (for the indentation). Not 100 % sure if it's a sensible one.

It's good, but it has one drawback in that the preview is worse as it doesn't show newlines:

Screenshot 2023-12-05 at 06 43 37

@gregorias
Copy link
Contributor Author

Here are some screenshots:

Screenshot 2023-12-05 at 06 50 17 Screenshot 2023-12-05 at 06 47 49

@gregorias gregorias requested a review from mrcjkb December 5, 2023 05:51
@mrcjkb mrcjkb merged commit 77a743f into mrcjkb:master Dec 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrcjkb mrcjkb mrcjkb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregorias @mrcjkb