- improved tsconfig.json

mrcwbr · Aug 8, 2023 · b3dd1b8 · b3dd1b8
1 parent ec878a1
commit b3dd1b8
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/src/ServiceContainer.ts b/src/ServiceContainer.ts
@@ -24,7 +24,7 @@ export default {
     }
 
     if (!service.instance) {
-      service.instance = service.factory();
+      service.instance = service.factory?.();
       service.factory = undefined;
     }
 
@@ -63,6 +63,6 @@ function getFactory(factoryOrClassReference: Factory | Function): Factory {
 
 type Factory = () => any;
 type Service = {
-  factory: () => any;
+  factory?: Factory;
   instance?: any;
 }
diff --git a/src/decorators.ts b/src/decorators.ts
@@ -7,7 +7,7 @@ export function inject(serviceIdOrTarget: Object | string, propertyKey?: string)
     };
   }
 
-  redefineObject(serviceIdOrTarget, propertyKey);
+  redefineObject(serviceIdOrTarget, propertyKey!);
 }
 
 function redefineObject(target: Object, propertyKey: string, serviceId?: string) {

diff --git a/tests/decorators.test.ts b/tests/decorators.test.ts
@@ -26,6 +26,7 @@ describe('decorators', () => {
 
     inject(anObject, 'aService');
 
+    // @ts-ignore
     expect(() => anObject.aService = jest.fn()).toThrow('Injected property [aService] can\'t be reset');
   });
 

diff --git a/tsconfig.json b/tsconfig.json
@@ -6,7 +6,10 @@
     "declaration": true,
     "esModuleInterop": true,
     "moduleResolution": "node",
-    "module": "commonjs"
+    "module": "commonjs",
+    "strict": true,
+    "noImplicitAny": true,
+    "strictPropertyInitialization": true
   },
   "include": [
     "src/**/*"