PointLight/SpotLight: Change default decay to 2 (#23897)

* PointLight/SpotLight: Change default decay to 2. * Updated screenshots. * Updated screenshots. * Update screenshot. * Update screenshot.
mrdoob · Nov 12, 2022 · df4a3a9 · df4a3a9
1 parent 87c581c
commit df4a3a9
Show file tree

Hide file tree

Showing 9 changed files with 4 additions and 4 deletions.
diff --git a/examples/screenshots/webgl_loader_md2.jpg b/examples/screenshots/webgl_loader_md2.jpg
diff --git a/examples/screenshots/webgl_materials_normalmap.jpg b/examples/screenshots/webgl_materials_normalmap.jpg
diff --git a/examples/screenshots/webgl_materials_subsurface_scattering.jpg b/examples/screenshots/webgl_materials_subsurface_scattering.jpg
diff --git a/examples/screenshots/webgl_mirror.jpg b/examples/screenshots/webgl_mirror.jpg
diff --git a/examples/screenshots/webgl_portal.jpg b/examples/screenshots/webgl_portal.jpg
diff --git a/examples/screenshots/webgl_refraction.jpg b/examples/screenshots/webgl_refraction.jpg
diff --git a/examples/screenshots/webgl_shadowmap_pointlight.jpg b/examples/screenshots/webgl_shadowmap_pointlight.jpg
diff --git a/src/lights/PointLight.js b/src/lights/PointLight.js
@@ -3,7 +3,7 @@ import { PointLightShadow } from './PointLightShadow.js';
 
 class PointLight extends Light {
 
-	constructor( color, intensity, distance = 0, decay = 1 ) {
+	constructor( color, intensity, distance = 0, decay = 2 ) {
 
 		super( color, intensity );
 
@@ -12,7 +12,7 @@ class PointLight extends Light {
 		this.type = 'PointLight';
 
 		this.distance = distance;
-		this.decay = decay; // for physically correct lights, should be 2.
+		this.decay = decay;
 
 		this.shadow = new PointLightShadow();
 

diff --git a/src/lights/SpotLight.js b/src/lights/SpotLight.js
@@ -4,7 +4,7 @@ import { Object3D } from '../core/Object3D.js';
 
 class SpotLight extends Light {
 
-	constructor( color, intensity, distance = 0, angle = Math.PI / 3, penumbra = 0, decay = 1 ) {
+	constructor( color, intensity, distance = 0, angle = Math.PI / 3, penumbra = 0, decay = 2 ) {
 
 		super( color, intensity );
 
@@ -20,7 +20,7 @@ class SpotLight extends Light {
 		this.distance = distance;
 		this.angle = angle;
 		this.penumbra = penumbra;
-		this.decay = decay; // for physically correct lights, should be 2.
+		this.decay = decay;
 
 		this.map = null;