Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLYLoader: convert vertex colors to linear #23342

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Conversation

gkjohnson
Copy link
Collaborator

Related issue: #23283

Description

Convert the loaded vertex colors from PLY from srgb to linear.

Tested using the "dolphins_colored.ply" file in the repo. All the vertex colors seem to be fully 0 or 1 in that file so changes in brightness are not so apparent but you can see the differences in the transition between colors on the rainbow dolphin.

BEFORE AFTER
image image

@gkjohnson
Copy link
Collaborator Author

How does this DeepScan plugin work that it marks new problems in files unrelated to the PR?

@mrdoob mrdoob added this to the r138 milestone Jan 26, 2022
@mrdoob
Copy link
Owner

mrdoob commented Jan 26, 2022

How does this DeepScan plugin work that it marks new problems in files unrelated to the PR?

Yeah. Still trying to figure how it works. You can ignore it...

@mrdoob mrdoob merged commit 145f712 into mrdoob:dev Jan 26, 2022
@mrdoob
Copy link
Owner

mrdoob commented Jan 26, 2022

Thanks!

@gkjohnson gkjohnson deleted the ply-srgb branch January 26, 2022 23:25
@curtainTan

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants