fix: allow control renderTarget encoding #23870
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Considering the Color Management updates (#23430, #23392), it seems like the right thing to do is to bring back the ability to control the encoding in which the pixels are rendered to the
renderTarget.The current behavior is that if I want an sRGB-encoded
renderTarget, theWebGLRendererwill write everything to it in Linear, except for the background color, which is going to be written in sRGB, which is not right.This PR fixes this behavior and gives the user control over the encoding of the
renderTarget.Should we add this to the next minor?
Related issues: #23251, #23278