Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Update IFC example to .outputEncoding = sRGBEncoding #25442

Closed

Conversation

donmccurdy
Copy link
Collaborator

Related:

Description

For now this PR changes the display of the IFC model in a probably-not-intended way. I believe after the PR above is merged to IFCjs, that should be resolved.

@donmccurdy
Copy link
Collaborator Author

/cc @agviegas - just FYI!

@donmccurdy donmccurdy marked this pull request as draft February 6, 2023 15:20
@donmccurdy
Copy link
Collaborator Author

Converting to draft while the upstream stuff is sorted out.

@agviegas
Copy link
Contributor

agviegas commented Feb 6, 2023

I'm submitting this PR. Is there anything I should do regarding this?

@donmccurdy
Copy link
Collaborator Author

Thanks @agviegas! My hope would be that ThatOpen/web-ifc-three#148 can be pulled into IFCLoader, at your convenience. It allows IFC models to display correctly when used in applications that follow the newer color management guidelines.

@agviegas
Copy link
Contributor

agviegas commented Feb 7, 2023

Ok, got it! Thanks a lot for the PR. We'll merge it as soon as possible.

@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 7, 2023

@donmccurdy It seems your PR at the web-ifc-three repo has been merged so I guess we can move on with this change, too?

@donmccurdy
Copy link
Collaborator Author

donmccurdy commented Apr 7, 2023

Agreed! I may need help to link the updated IFC loader into the three.js repository first.

@donmccurdy
Copy link
Collaborator Author

The IFCLoader in three.js will need to be updated to the latest version in order to use the new color management APIs. Until then, we do not need this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants