Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColorManagement: Remove redundant enables #25868

Merged
merged 2 commits into from
Apr 17, 2023
Merged

ColorManagement: Remove redundant enables #25868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fc3b1e
ColorManagement: Remove redundant enables.
donmccurdy Apr 17, 2023
d53c34b
Fix typos
donmccurdy Apr 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions docs/scenes/bones-browser.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
import {
Bone,
Color,
ColorManagement,
CylinderGeometry,
DoubleSide,
Float32BufferAttribute,
Expand All @@ -61,8 +60,6 @@
import { GUI } from 'three/addons/libs/lil-gui.module.min.js';
import { OrbitControls } from 'three/addons/controls/OrbitControls.js';

ColorManagement.enabled = true;

let gui, scene, camera, renderer, orbit, lights, mesh, bones, skeletonHelper;

const state = {
Expand Down
3 changes: 0 additions & 3 deletions docs/scenes/ccdiksolver-browser.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
import {
Bone,
Color,
ColorManagement,
CylinderGeometry,
DoubleSide,
Float32BufferAttribute,
Expand All @@ -65,8 +64,6 @@
import { GUI } from 'three/addons/libs/lil-gui.module.min.js';
import { OrbitControls } from 'three/addons/controls/OrbitControls.js';

ColorManagement.enabled = true;

let gui, scene, camera, renderer, orbit, mesh, bones, skeletonHelper, ikSolver;

const state = {
Expand Down
3 changes: 0 additions & 3 deletions docs/scenes/geometry-browser.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
CapsuleGeometry,
CircleGeometry,
Color,
ColorManagement,
ConeGeometry,
Curve,
CylinderGeometry,
Expand Down Expand Up @@ -82,8 +81,6 @@
import { GUI } from 'three/addons/libs/lil-gui.module.min.js';
import { OrbitControls } from 'three/addons/controls/OrbitControls.js';

ColorManagement.enabled = true;

const twoPi = Math.PI * 2;

class CustomSinCurve extends Curve {
Expand Down
2 changes: 0 additions & 2 deletions docs/scenes/material-browser.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@
import { GUI } from 'three/addons/libs/lil-gui.module.min.js';
import { RoomEnvironment } from 'three/addons/environments/RoomEnvironment.js';

THREE.ColorManagement.enabled = true;

const constants = {

combine: {
Expand Down
2 changes: 0 additions & 2 deletions editor/js/Editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import { Strings } from './Strings.js';
import { Storage as _Storage } from './Storage.js';
import { Selector } from './Viewport.Selector.js';

THREE.ColorManagement.enabled = true;

var _DEFAULT_CAMERA = new THREE.PerspectiveCamera( 50, 1, 0.01, 1000 );
_DEFAULT_CAMERA.name = 'Camera';
_DEFAULT_CAMERA.position.set( 0, 5, 10 );
Expand Down
2 changes: 0 additions & 2 deletions editor/js/libs/app/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@
window.THREE = THREE; // Used by APP Scripts.
window.VRButton = VRButton; // Used by APP Scripts.

THREE.ColorManagement.enabled = true;

var loader = new THREE.FileLoader();
loader.load( 'app.json', function ( text ) {

Expand Down
2 changes: 0 additions & 2 deletions examples/css2d_label.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@

import { GUI } from 'three/addons/libs/lil-gui.module.min.js';

THREE.ColorManagement.enabled = true;

let gui;

let camera, scene, renderer, labelRenderer;
Expand Down
2 changes: 0 additions & 2 deletions examples/jsm/offscreen/scene.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import * as THREE from '../../../build/three.module.js';

THREE.ColorManagement.enabled = true;

let camera, scene, renderer, group;

function init( canvas, width, height, pixelRatio, path ) {
Expand Down
2 changes: 0 additions & 2 deletions examples/misc_boxselection.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@
import { SelectionBox } from 'three/addons/interactive/SelectionBox.js';
import { SelectionHelper } from 'three/addons/interactive/SelectionHelper.js';

THREE.ColorManagement.enabled = true;

let container, stats;
let camera, scene, renderer;

Expand Down
2 changes: 0 additions & 2 deletions examples/misc_controls_drag.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@

import { DragControls } from 'three/addons/controls/DragControls.js';

THREE.ColorManagement.enabled = true;

let container;
let camera, scene, renderer;
let controls, group;
Expand Down
2 changes: 0 additions & 2 deletions examples/misc_controls_map.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@

import { MapControls } from 'three/addons/controls/MapControls.js';

THREE.ColorManagement.enabled = true;

let camera, controls, scene, renderer;

init();
Expand Down
2 changes: 0 additions & 2 deletions examples/misc_controls_orbit.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@

import { OrbitControls } from 'three/addons/controls/OrbitControls.js';

THREE.ColorManagement.enabled = true;

let camera, controls, scene, renderer;

init();
Expand Down
2 changes: 0 additions & 2 deletions examples/misc_controls_pointerlock.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,6 @@

import { PointerLockControls } from 'three/addons/controls/PointerLockControls.js';

THREE.ColorManagement.enabled = true;

let camera, scene, renderer, controls;

const objects = [];
Expand Down
2 changes: 0 additions & 2 deletions examples/misc_controls_trackball.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@

import { TrackballControls } from 'three/addons/controls/TrackballControls.js';

THREE.ColorManagement.enabled = true;

let perspectiveCamera, orthographicCamera, controls, scene, renderer, stats;

const params = {
Expand Down
2 changes: 0 additions & 2 deletions examples/misc_controls_transform.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@
import { OrbitControls } from 'three/addons/controls/OrbitControls.js';
import { TransformControls } from 'three/addons/controls/TransformControls.js';

THREE.ColorManagement.enabled = true;

let cameraPersp, cameraOrtho, currentCamera;
let scene, renderer, control, orbit;

Expand Down
2 changes: 0 additions & 2 deletions examples/misc_exporter_draco.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@
import { DRACOExporter } from 'three/addons/exporters/DRACOExporter.js';
import { GUI } from 'three/addons/libs/lil-gui.module.min.js';

THREE.ColorManagement.enabled = true;

let scene, camera, renderer, exporter, mesh;

const params = {
Expand Down
2 changes: 0 additions & 2 deletions examples/misc_exporter_stl.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@
import { STLExporter } from 'three/addons/exporters/STLExporter.js';
import { GUI } from 'three/addons/libs/lil-gui.module.min.js';

THREE.ColorManagement.enabled = true;

let scene, camera, renderer, exporter, mesh;

const params = {
Expand Down
2 changes: 0 additions & 2 deletions examples/physics_ammo_break.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@
import { ConvexObjectBreaker } from 'three/addons/misc/ConvexObjectBreaker.js';
import { ConvexGeometry } from 'three/addons/geometries/ConvexGeometry.js';

THREE.ColorManagement.enabled = true;

// - Global variables -

// Graphics variables
Expand Down
2 changes: 0 additions & 2 deletions examples/physics_ammo_cloth.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@

import { OrbitControls } from 'three/addons/controls/OrbitControls.js';

THREE.ColorManagement.enabled = true;

// Graphics variables
let container, stats;
let camera, controls, scene, renderer;
Expand Down
2 changes: 0 additions & 2 deletions examples/physics_ammo_rope.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@

import { OrbitControls } from 'three/addons/controls/OrbitControls.js';

THREE.ColorManagement.enabled = true;

// Graphics variables
let container, stats;
let camera, controls, scene, renderer;
Expand Down
2 changes: 0 additions & 2 deletions examples/physics_ammo_terrain.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@

import { OrbitControls } from 'three/addons/controls/OrbitControls.js';

THREE.ColorManagement.enabled = true;

// Heightfield parameters
const terrainWidthExtents = 100;
const terrainDepthExtents = 100;
Expand Down
2 changes: 0 additions & 2 deletions examples/physics_ammo_volume.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@
import { OrbitControls } from 'three/addons/controls/OrbitControls.js';
import * as BufferGeometryUtils from 'three/addons/utils/BufferGeometryUtils.js';

THREE.ColorManagement.enabled = true;

// Graphics variables
let container, stats;
let camera, controls, scene, renderer;
Expand Down
2 changes: 0 additions & 2 deletions examples/webaudio_sandbox.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@

import { FirstPersonControls } from 'three/addons/controls/FirstPersonControls.js';

THREE.ColorManagement.enabled = true;

let camera, controls, scene, renderer, light;

let material1, material2, material3;
Expand Down
2 changes: 0 additions & 2 deletions examples/webaudio_timing.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@

import { OrbitControls } from 'three/addons/controls/OrbitControls.js';

THREE.ColorManagement.enabled = true;

let scene, camera, renderer, clock;

const objects = [];
Expand Down
2 changes: 0 additions & 2 deletions examples/webgl2_materials_texture3d_partialupdate.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@

}

THREE.ColorManagement.enabled = true;

const INITIAL_CLOUD_SIZE = 128;

let renderer, scene, camera;
Expand Down
2 changes: 0 additions & 2 deletions examples/webgl2_volume_cloud.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@

}

THREE.ColorManagement.enabled = true;

let renderer, scene, camera;
let mesh;

Expand Down
2 changes: 0 additions & 2 deletions examples/webgl_buffergeometry_compression.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@
import { TeapotGeometry } from 'three/addons/geometries/TeapotGeometry.js';
import { GUI } from 'three/addons/libs/lil-gui.module.min.js';

THREE.ColorManagement.enabled = true;

const statsEnabled = true;

let container, stats, gui;
Expand Down
2 changes: 0 additions & 2 deletions examples/webgl_buffergeometry_glbufferattribute.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@

import Stats from 'three/addons/libs/stats.module.js';

THREE.ColorManagement.enabled = true;

let container, stats;

let camera, scene, renderer;
Expand Down
2 changes: 0 additions & 2 deletions examples/webgl_buffergeometry_indexed.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@
import Stats from 'three/addons/libs/stats.module.js';
import { GUI } from 'three/addons/libs/lil-gui.module.min.js';

THREE.ColorManagement.enabled = true;

let camera, scene, renderer, stats;

let mesh;
Expand Down
2 changes: 0 additions & 2 deletions examples/webgl_buffergeometry_points.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@

import Stats from 'three/addons/libs/stats.module.js';

THREE.ColorManagement.enabled = true;

let container, stats;

let camera, scene, renderer;
Expand Down
2 changes: 0 additions & 2 deletions examples/webgl_buffergeometry_points_interleaved.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@

import Stats from 'three/addons/libs/stats.module.js';

THREE.ColorManagement.enabled = true;

let container, stats;

let camera, scene, renderer;
Expand Down
2 changes: 0 additions & 2 deletions examples/webgl_camera_array.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@

import * as THREE from 'three';

THREE.ColorManagement.enabled = true;

let camera, scene, renderer;
let mesh;
const AMOUNT = 6;
Expand Down
2 changes: 0 additions & 2 deletions examples/webgl_clipping.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@

import { OrbitControls } from 'three/addons/controls/OrbitControls.js';

THREE.ColorManagement.enabled = true;

let camera, scene, renderer, startTime, object, stats;

init();
Expand Down
2 changes: 0 additions & 2 deletions examples/webgl_clipping_advanced.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@

import { OrbitControls } from 'three/addons/controls/OrbitControls.js';

THREE.ColorManagement.enabled = true;

function planesFromMesh( vertices, indices ) {

// creates a clipping volume from a convex triangular mesh
Expand Down
2 changes: 0 additions & 2 deletions examples/webgl_clipping_intersection.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@

import { OrbitControls } from 'three/addons/controls/OrbitControls.js';

THREE.ColorManagement.enabled = true;

let camera, scene, renderer;

const params = {
Expand Down
2 changes: 0 additions & 2 deletions examples/webgl_clipping_stencil.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@
import { GUI } from 'three/addons/libs/lil-gui.module.min.js';
import Stats from 'three/addons/libs/stats.module.js';

THREE.ColorManagement.enabled = true;

let camera, scene, renderer, object, stats;
let planes, planeObjects, planeHelpers;
let clock;
Expand Down
2 changes: 0 additions & 2 deletions examples/webgl_decals.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@
import { GLTFLoader } from 'three/addons/loaders/GLTFLoader.js';
import { DecalGeometry } from 'three/addons/geometries/DecalGeometry.js';

THREE.ColorManagement.enabled = true;

const container = document.getElementById( 'container' );

let renderer, scene, camera, stats;
Expand Down
2 changes: 0 additions & 2 deletions examples/webgl_effects_stereo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@

import { StereoEffect } from 'three/addons/effects/StereoEffect.js';

THREE.ColorManagement.enabled = true;

let container, camera, scene, renderer, effect;

const spheres = [];
Expand Down
2 changes: 0 additions & 2 deletions examples/webgl_furnace_test.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@

import * as THREE from 'three';

THREE.ColorManagement.enabled = true;

let scene, camera, renderer, radianceMap;

const COLOR = 0xcccccc;
Expand Down
2 changes: 0 additions & 2 deletions examples/webgl_geometries.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@

import Stats from 'three/addons/libs/stats.module.js';

THREE.ColorManagement.enabled = true;

let camera, scene, renderer, stats;

init();
Expand Down
2 changes: 0 additions & 2 deletions examples/webgl_geometries_parametric.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@
import { ParametricGeometry } from 'three/addons/geometries/ParametricGeometry.js';
import { ParametricGeometries } from 'three/addons/geometries/ParametricGeometries.js';

THREE.ColorManagement.enabled = true;

let camera, scene, renderer, stats;

init();
Expand Down
Loading