Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples: Updates for color management (pt2) #25882

Merged
merged 7 commits into from
Apr 20, 2023
Merged

Examples: Updates for color management (pt2) #25882

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
602dbbc
Examples: Update misc_exporter_gltf and misc_exporter_ply for color m…
donmccurdy Apr 18, 2023
8ee2337
Examples: Update 3MF examples for color management.
donmccurdy Apr 18, 2023
656ce09
Examples: Update webgl_loader_draco for color management.
donmccurdy Apr 18, 2023
517fa20
Examples: Update LDraw examples for color management.
donmccurdy Apr 18, 2023
3e3922c
Loaders: Update color space assignmentin 3MF, LDraw, and SVG loaders.
donmccurdy Apr 19, 2023
218b14c
LDrawLoader: Clean up, fix emissive.
donmccurdy Apr 19, 2023
cea20cd
LDrawLoader: Clean up
donmccurdy Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/jsm/loaders/LDrawLoader.js
View file
Open in desktop
donmccurdy marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -2165,8 +2165,8 @@ class LDrawLoader extends Loader {
let code = null;

// Triangle and line colors
let fillColor = 0xFF00FF;
let edgeColor = 0xFF00FF;
let fillColor = '#FF00FF';
let edgeColor = '#FF00FF';
WestLangley marked this conversation as resolved.
Show resolved Hide resolved

// Transparency
let alpha = 1;
Expand Down