GLTFLoader: Explicitly set r, g, b in setRGB() calls.
#26691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
changed the title
setRGB() calls.
donmccurdy
approved these changes
Sep 4, 2023
| @@ -665,7 +665,7 @@ class GLTFMaterialsUnlitExtension { | |||
|
|
|||
| const array = metallicRoughness.baseColorFactor; | |||
|
|
|||
| materialParams.color.setRGB( ...array, LinearSRGBColorSpace ); | |||
| materialParams.color.setRGB( array[ 0 ], array[ 1 ], array[ 2 ], LinearSRGBColorSpace ); | |||
There was a problem hiding this comment.
I think all of the spread operations are technically safe, except this one – the other factors do not allow >3 components. For consistency and safety perhaps it's better that we write them all this way though, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #26534 (comment)
Description
Since r156,
GLTFLoaderhas used array spread syntax (...) to callsetRGB. This can lead to the fourth argument (typically opacity) of an array to be passed as an argument to thecolorSpaceparameter. The actual color space argumentLinearSRGBColorSpaceis ignored.This PR passes arguments for
r,g,bparameters explicitly, i.e. instead ofsetRGB( ...array, LinearSRGBColorSpace)we call
setRGB( array[ 0 ], array [ 1 ], array[ 2 ], LinearSRGBColorSpace)