Skip to content

Conversation

@ademola-lou
Copy link

@ademola-lou ademola-lou commented Sep 29, 2025

Description

A simple implementation of mesh blend based on mesh seams smoothing [https://www.jacktollenaar.top/mesh-seam-smoothing-blending#h.50wag6hqg9gh]

https://rawcdn.githack.com/ademola-lou/three.js/refs/heads/meshblend-demo/examples/webgpu_postprocessing_meshblend.html

Screenshot 2025-09-28 231147


setup(){
const CustomHash = wgslFn(`
fn Hash(p: vec3f) -> f32 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please implement all shader code as TSL. Otherwise it won't work with the WebGL backend.


const _size = /*@__PURE__*/ new Vector2();

class MeshBlendNode extends TempNode {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please honor the code style of the project. I suggest you configure your editor such that it supports the ESLint config from the project.

@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 29, 2025

Please remove any build files from the PR.

@ademola-lou
Copy link
Author

@Mugen87
Thanks ill take a look

@ademola-lou ademola-lou requested a review from Mugen87 October 2, 2025 08:40
@ademola-lou
Copy link
Author

i have removed the build folder not sure why the conflict is still showing up

@Mugen87
Copy link
Collaborator

Mugen87 commented Oct 5, 2025

i have removed the build folder not sure why the conflict is still showing up

You are not supposed to remove the build files from the PR. You should only revert the related changes.

If you have issues with fixing this, I suggest you use the reset git command and reset all commits you have done so far. You then undo the changes to the build files and commit the remaining code as a single new commit. In this way, the PR has a clean commit history.

@Mugen87
Copy link
Collaborator

Mugen87 commented Oct 15, 2025

Another option is to file a new PR from a new branch which is based on latest dev. Just don't commit the build files and the PR should be in a valid state.

… inspector nodes, tidy formatting

- remove unused three/tsl imports (add, vec3, vec4, colorToDirection, sample, depth)
- drop unused local variable (box) and unused MRT inspector nodes (diffuse, normal, velocity)
- remove unused sceneNormal sample helper and related comment
- minor formatting/spacing and string-quote cleanups for consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants