- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 36.1k
Feat mesh blend #31977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Feat mesh blend #31977
Conversation
|  | ||
| setup(){ | ||
| const CustomHash = wgslFn(` | ||
| fn Hash(p: vec3f) -> f32 { | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please implement all shader code as TSL. Otherwise it won't work with the WebGL backend.
|  | ||
| const _size = /*@__PURE__*/ new Vector2(); | ||
|  | ||
| class MeshBlendNode extends TempNode { | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please honor the code style of the project. I suggest you configure your editor such that it supports the ESLint config from the project.
| Please remove any build files from the PR. | 
| @Mugen87 | 
| i have removed the build folder not sure why the conflict is still showing up | 
| 
 You are not supposed to remove the build files from the PR. You should only revert the related changes. If you have issues with fixing this, I suggest you use the  | 
| Another option is to file a new PR from a new branch which is based on latest  | 
4f0edc0    to
    70226b4      
    Compare
  
    … inspector nodes, tidy formatting - remove unused three/tsl imports (add, vec3, vec4, colorToDirection, sample, depth) - drop unused local variable (box) and unused MRT inspector nodes (diffuse, normal, velocity) - remove unused sceneNormal sample helper and related comment - minor formatting/spacing and string-quote cleanups for consistency
Description
A simple implementation of mesh blend based on mesh seams smoothing [https://www.jacktollenaar.top/mesh-seam-smoothing-blending#h.50wag6hqg9gh]
https://rawcdn.githack.com/ademola-lou/three.js/refs/heads/meshblend-demo/examples/webgpu_postprocessing_meshblend.html