Add validation to prevent multiple class assignment#646
Add validation to prevent multiple class assignment#646Dym03 wants to merge 2 commits intomrlvsb:masterfrom
Conversation
Kobzol
left a comment
There was a problem hiding this comment.
Thanks for the PR! I'm not sure if we can do this before we have class types (similarly as to the recently added task types). Because right now it's quite common to have a student in multiple classes, because there can be e.g. lecture + laboratory class for the same subject, or exam + laboratory classes for the same subject.
|
That is true, will leave it here, if the class types are added, then it could be finished :). Just to leave the frontend in a good state is there any way to get the inbus import working on a local machine ? Because right now i have a bulk import in a loading state, maybe due to wrong semester_id. |
|
I'm afraid not, we can't give out Inbus API keys to students, I think :( |
|
At this point, we cannot give out INBUS API keys. Sorry for that. |
Fixes #445
Updated validation before adding user to a class to prevent one student having multiple classes from same subject.
Updated errors returned to frontend. Split returned users into 2 groups for easier handling. Please do check if the inbus part is correct, I am not able to run the inbus import, maybe due to a wrong local setup.