Open
Conversation
c3d6258 to
75d55af
Compare
…d frontend. Add api endpoint to list all classrooms.
75d55af to
0f590c1
Compare
- Implement custom form for ClassroomIpRange with IP range/CIDR input fields - Add widget to AssignedTaskAdmin
…using POST requests
d432a30 to
48c45f6
Compare
Collaborator
|
Hi, thanks for the PR! This looks really cool. There is some functionality that is not strictly related to IP filtering, so it would be great to merge it separately. Could you split the change with the custom error pages to a separate PR please? In the error page it would be nice to use the normal layout and make it a "normal page", with the header, notifications and everything, so that it is not just a bare white page. |
48c45f6 to
6e5c674
Compare
6e5c674 to
40b85c1
Compare
Kobzol
reviewed
Oct 31, 2025
Collaborator
|
This should be somehow combined with #787, so that we don't have two ways of combining rooms. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow submission uploads and task viewing only from defined Classrooms IP ranges.
Models:
EditTask page:
IP-based access control:
Administrator page:
Related to #586