Evaluator Scheduler - Automated Deployment from GitHub#827
Open
JersyJ wants to merge 3 commits intomrlvsb:masterfrom
Open
Evaluator Scheduler - Automated Deployment from GitHub#827JersyJ wants to merge 3 commits intomrlvsb:masterfrom
JersyJ wants to merge 3 commits intomrlvsb:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the deployment service and GitHub Actions workflow to support automated deployments with improved health-check behavior (HTTP or Docker HEALTHCHECK) and configurable timeouts, plus clearer GitHub job summaries per service.
Changes:
- Add Docker HEALTHCHECK-based health check fallback when
healthcheck_urlis not provided, and introduce configurable health check timeout (global + per-request override). - Extend
deployment_service/deploy.pyto accept--health-check-timeoutand includeservice_namein the GitHub Job Summary titles. - Update docs and CI workflow to describe/use the new health-check behavior and deploy an additional
evaluator_schedulerservice.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/docs/02-developers-guide/02-deployment.mdx | Documents Docker-healthcheck fallback and timeout override behavior. |
| deployment_service/tests/test_deployment.py | Updates health-check assertions and adds Docker-healthcheck test cases. |
| deployment_service/deploy.py | Adds --health-check-timeout, passes it to server, and improves summary titles with service name. |
| deployment_service/app/models.py | Makes healthcheck_url optional and adds health_check_timeout to the request schema. |
| deployment_service/app/main.py | Wires optional healthcheck_url and timeout into DeploymentManager. |
| deployment_service/app/deployment.py | Implements HTTP vs Docker health-check paths and uses configurable timeout. |
| deployment_service/app/config.py | Adds global health_check_timeout setting. |
| .github/workflows/ci.yml | Adds evaluator scheduler deployment invocation in CI deploy job. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.