Skip to content

fix(install): default to ~/.local/bin for unprivileged installs #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stevensmith37 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(install): default to ~/.local/bin for unprivileged installs #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ set -e
# curl -fsSL https://raw.githubusercontent.com/mrmaxsteel/mindspec/main/install.sh | sh -s -- --force

REPO="mrmaxsteel/mindspec"
INSTALL_DIR="${INSTALL_DIR:-/usr/local/bin}"
INSTALL_DIR="${INSTALL_DIR:-$HOME/.local/bin}"
BINARY_NAME="mindspec"
FORCE_INSTALL="${FORCE_INSTALL:-false}"
LOG_FILE="${HOME}/.mindspec/install.log"
Expand Down Expand Up @@ -258,17 +258,19 @@ Got: $ACTUAL_CHECKSUM"
info "Extracting..."
tar -xzf "$TMP_DIR/$ARCHIVE_NAME" -C "$TMP_DIR"

# Ensure install directory exists before privilege check
mkdir -p "$INSTALL_DIR"

# Check privileges before attempting install
if ! check_privileges; then
error "Cannot write to $INSTALL_DIR"
fi

# Check for existing installation
check_existing_installation

# Install binary
info "Installing to ${INSTALL_DIR}/${BINARY_NAME}..."
mkdir -p "$INSTALL_DIR"
mv "$TMP_DIR/$BINARY_NAME" "$INSTALL_DIR/$BINARY_NAME"
chmod +x "$INSTALL_DIR/$BINARY_NAME"

Expand Down
Loading