ARIA activedescendant, label

[Lewiscowles1986]

Purpose (TL;DR)

To enable screen reader software and assistive ARIA aware technologies to announce each item as highlighted prior to selection.
Fixes #77

Background (Problem in detail)

Detailed in #77

Solution

Uses additional ARIA attributes to announce choices prior to selection, differentiating from selection announcement.
Supporting DOM changes. (likely "choice" constant will need to be configurable).

Other solutions considered

Please see ticket.

• ARIA live region (did not announce on selection).

How to verify - mandatory

1. Check out this branch
2. npm ci
3. npm run start
4. use http://localhost:8080/
5. download browser extension for Google Chrome (or any screenreader) link

Contributor declaration

• I've read and followed the contributing document.
• The code I am submitting is mine to submit and is done so under the license of this repository.
• Where features have been changed, there are tests and documentation to accompany the entire contribution.

• All tests remained passing as the behavior of these attributes is not owned by plete.
• Documentation should not be necessary as this is a transparent change.
• Please let me know. I expect the first-cut is an improvement, but may need further improvement.

[Lewiscowles1986]

Stopped short of changing this as I felt you may have ideas, opinions, insights into the best place to make Choice: localizable.

Begs the question, should there be an optional localization parameter, config value, that can be stored in state, so server-side request components forward a locale from the initialization of the component?

It feels mildly out of scope for this, but perhaps having that machinery is more important than serving a particularly rigid feature under the guise of accessibility?

[mroderick]

Localisation does feel a bit out of scope here ... perhaps we can tackle it in a separate issue, so we can get this improvement over the finish line?

[Lewiscowles1986]

😂 because of the CDN usage when deploying, the changes are not actually visible.
https://youtu.be/WKKFbsL9vao

[mroderick]

Would you mind adding some test coverage that asserts that the correct ARIA label is being set?

[mroderick]

Localisation does feel a bit out of scope here ... perhaps we can tackle it in a separate issue, so we can get this improvement over the finish line?

[codecov-io]

Codecov Report

Merging #78 (f19cc50) into master (de63b80) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #78   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines          239       242    +3     
=========================================
+ Hits           239       242    +3     

Flag	Coverage Δ
unit	100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
lib/clear-suggestions.js	100.00% <100.00%> (ø)
lib/highlight.js	100.00% <100.00%> (ø)
lib/render.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de63b80...f19cc50. Read the comment docs.

[Lewiscowles1986]

Hmm.. Says 100% coverage. Did I miss something the automated checkers missed?