Fix 168 #196
Closed
Fix 168 #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To do:
|
In order to convert the generated CSV back to the most accurate JSON possible, the module must still insert `[]` for unwound empty array values. However, there are some legitimate cases where users want to be able to have the module ignore these values so that the generated CSV is a bit more user-friendly, depending on the data being converted. This new option allows users the ability to achieve this without impacting existing use cases, as the user has opted to specify an option which may impact the ability to convert the CSV back to JSON later on. Fixes #168
Jeff-Tian
reviewed
Oct 14, 2022
| @@ -656,15 +656,24 @@ function runTests(jsonTestData, csvTestData) { | |||
| }); | |||
| }); | |||
|
|
|||
| // Test case for #168 | |||
|
Closing as this will require revisiting anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background Information
3.15.0I have...