Fix empty array literals being added when an empty array is provided and keys option is provided #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…was given and the keys option was set
… data is passed and the keys option is set
Altioc
commented
Sep 20, 2024
| @@ -457,7 +457,7 @@ export const Json2Csv = function(options: FullJson2CsvOptions) { | |||
| */ | |||
| function convert(data: object[]) { | |||
| // Single document, not an array | |||
| if (utils.isObject(data) && !data.length) { | |||
There was a problem hiding this comment.
All arrays are typed as object's and data.length of an empty array is 0 and !0 is true which is the source of the bug.
|
Hi @Altioc, thanks for finding and opening a pull request to fix this! I'll get this merged in (don't worry about the lint failing - I'll tackle that when I run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background Information
Fixes issue(s): # Empty array literals gets added if you call
json2csvwith an empty array fordatawhile also providingoptions.keys.given:
converter.json2csv([], { keys: ['header1', 'header2'] });Before:
After:
Proposed release version:
5.5.6I have...