Enhance photo size retrieval by combining high-resolution and standard resolutions

[ismaelsousa]

What

This PR exposes all possible photo resolutions for Android devices. Some Android devices do not expose all resolutions

When we check the sizes coming only from getSupportedResolutions the highest resolution ("4080x3072") is not there

• Example:

cameraInfoInternal.getSupportedResolutions(ImageFormat.JPEG)

But when we use the getSupportedHighResolutions we can get it

• Example:

cameraInfoInternal.getSupportedHighResolutions(ImageFormat.JPEG)

So if we combine and remove the duplicates we can the all sizes possible

• Example:

combined

Changes

This PR combines the highest and standard photo resolutions

Tested on

Moto G52, Android 13

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-vision-camera	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 31, 2025 6:03pm

[ismaelsousa]

@mrousavy does it make sense?

[mrousavy]

As far as I know, this high quality resolution cannot be selected by CameraX.

Did you actually try using it?

If yes, does the resulting photo actually have the same dimension?

And, does Video and Frame Processor still work if you use high resolution?

[ismaelsousa]

Did you actually try using it?

I tried on my phone, which is one of those that exposes the highest in the other method. Maybe I can ship as a beta test for my users and get some feedback

If yes, does the resulting photo actually have the same dimension?

Yes, it usually is the same as the OEM camera app

And, does Video and Frame Processor still work if you use high resolution?

Yes, because we use the videoWidth and videoHeight for video and frame. This change only exposes a new value for photo resolution.

Most Android phones expose the highest resolution in the way you created, it's annoying that some manufacturers don't

[mrousavy]

I'm sorry but your answers were not fully concise

I tried on my phone, which is one of those that exposes the highest in the other method. Maybe I can ship as a beta test for my users and get some feedback

So you're saying yes, this PR makes a difference - without it you shoot lower resolution photos?

Yes, because we use the videoWidth and videoHeight for video and frame. This change only exposes a new value for photo resolution.

Yes but keep in mind that the pipeline combines capture requests - so if a high resolution photo stream is added, it can reduce the video stream. Even if you have higher videoWidth - it might not be able to match that due to bandwidth constraints.
So my question; did you actually test if this works normally? With the highest available video resolution? Did you check if recording actually works?