Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add GS1 DataBar and GS1 DataBar Expanded on iOS #3403

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

enkhjile
Copy link

@enkhjile enkhjile commented Feb 8, 2025

What

This PR adds support for GS1 Data Bar and GS1 Data Bar for code scanner on iOS.

Edit:
I've implemented this because of the GS1 barcode usage in Japan. We're using this amazing library of yours in iOS app for pharmacies to recognize the drug types by GS1 code. Recently, GS1 stacked version are becoming popular due to its small space usage. Right now we're using patched version of this and would like to include it in upstream. Thank you

Changes

Included gs1DataBar and gs1DataBarExtended in code type matching logic.

Tested on

  • iPhone 13 mini
  • iPhone SE 3rd generation
  • iPad 15 Pro Max

Related issues

#843

Copy link

vercel bot commented Feb 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-vision-camera ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 0:23am

@enkhjile enkhjile changed the title fix: enable gs1DataBar and gs1DataBarExtended on the native side fix: add gs1DataBar and gs1DataBarExtended on iOS Feb 8, 2025
@enkhjile enkhjile changed the title fix: add gs1DataBar and gs1DataBarExtended on iOS fix: add GS1 DataBar and GS1 DataBar Expanded on iOS Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant