Skip to content
This repository was archived by the owner on Mar 18, 2023. It is now read-only.

Upgrades older Tapable.plugin methods to new hook/tap methods #173

Merged
merged 2 commits into from
Dec 18, 2020

Conversation

drolsen
Copy link
Contributor

@drolsen drolsen commented Jan 15, 2019

Webpack 4 has moved away from Tapable.plugin methods for new API hook/tap methods.

Please note, this moves the normalModuleFactory usage outside of the compiler.hooks.compilation tap due to scope change during API abstraction that leads to normalModuleFactory indexOf to never find a match unless re-scoped to the root of apply.

#171
webpack/webpack#6568

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants