Skip to content

refactor(constants): enforce StatusEnum in tests — replace hardcoded status strings (#3533)#3537

Merged
mrveiss merged 2 commits intoDev_new_guifrom
issue-3533
Apr 5, 2026
Merged

refactor(constants): enforce StatusEnum in tests — replace hardcoded status strings (#3533)#3537
mrveiss merged 2 commits intoDev_new_guifrom
issue-3533

Conversation

@mrveiss
Copy link
Copy Markdown
Owner

@mrveiss mrveiss commented Apr 5, 2026

Summary

Replaces raw status string literals in co-located orchestration test files with TaskStatus enum constants from constants/status_enums.py.

Changes

  • orchestration/dag_executor_test.py — 7 assertions ("completed", "failed") → TaskStatus.COMPLETED.value / TaskStatus.FAILED.value
  • orchestration/variable_resolver_test.py — 12 occurrences (assertions, default arg values, constructor args) → enum constants
  • orchestration/error_handler_test.py — 11 occurrences (constructor args, assertions) → enum constants

Why

When a status value is renamed in the enum, tests using raw strings silently pass but test the wrong value. Using TaskStatus.X.value breaks at import if the constant is removed.

Skipped

Closes #3533

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 5, 2026

✅ SSOT Configuration Compliance: Passing

🎉 No hardcoded values detected that have SSOT config equivalents!

@mrveiss mrveiss merged commit 01ec58d into Dev_new_gui Apr 5, 2026
4 of 5 checks passed
@mrveiss mrveiss deleted the issue-3533 branch April 5, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant