If not interactive, do nothing #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the shell is not an interactive shell, return from the bashrc directly. Avoid sourcing unnecessary config for a shell you'll never see.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the shell is not an interactive shell, return from the bashrc directly. Avoid sourcing unnecessary config for a shell you'll never see.
This line should be at the top of .bashrc, so if someone source this file from his own .bashrc he/she is better of moving this line to his file.
But it is nonetheless effective here, and as one of this project use-case is to be a model for people own config or to be systematically install on shared machine account as .bashrc, I think it is a good things to add.
Best Regards,
Aeredren