-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: fix semantic linebreaks #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 19 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
e5b3ec3
fix semantic linebreaks
mschoettle 4880641
use markdownlint-cli2 action
mschoettle ba2de5e
run container
mschoettle a43ec35
run container
mschoettle 41c4b04
run container
mschoettle 7bbfdb6
run container
mschoettle 3f2c9eb
run container
mschoettle b4f7608
run container
mschoettle 8528206
run container
mschoettle 0aa8e82
run container
mschoettle c661d20
run container
mschoettle 4fea801
run container
mschoettle 59eb18c
test annotation
mschoettle c993749
test step summary
mschoettle c979204
test step summary
mschoettle baabcd7
test step summary
mschoettle b9fe408
test sarif formatter
mschoettle 3eb91ec
fix permission denied
mschoettle 8cb9250
fix permission denied
mschoettle 4815c6e
fix permission denied
mschoettle b1b1d97
fix permission denied
mschoettle f9adfb6
check markdownlint results
mschoettle 14a555f
remove violations
mschoettle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # https://github.com/DavidAnson/markdownlint-cli2#markdownlint-cli2yaml | ||
|
|
||
| # additional configuration to the config in the root of the project | ||
| # this additional config is used during the markdownlint CI job | ||
|
|
||
| # use custom rule contained in supplementary rules image as a workaround | ||
| # more details: https://github.com/DavidAnson/vscode-markdownlint/issues/336 | ||
| customRules: | ||
| # Enforce one sentence per line | ||
| # semantic line breaks (https://sembr.org/) | ||
| # See: https://github.com/DavidAnson/markdownlint/pull/719 | ||
| - "markdownlint-rule-max-one-sentence-per-line" | ||
|
|
||
| outputFormatters: | ||
| - - markdownlint-cli2-formatter-pretty | ||
| - - markdownlint-cli2-formatter-sarif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,5 +29,20 @@ jobs: | |
| run: uv lock --locked | ||
| - name: Run pre-commit | ||
| uses: pre-commit/[email protected] | ||
| - name: Run markdownlint | ||
| uses: YannickTeKulve/[email protected] | ||
| with: | ||
| image: davidanson/markdownlint-cli2-rules:v0.14.0 | ||
| # node user does not have permissions to workspace due to user id mismatch | ||
| options: -v ${{ github.workspace }}:/workdir --user root | ||
| run: markdownlint-cli2 --config .github/markdownlint/.markdownlint-cli2.yaml "**/*.md" || true | ||
| - name: Upload SARIF file | ||
| uses: github/codeql-action/upload-sarif@v3 | ||
| with: | ||
| # Path to SARIF file relative to the root of the repository | ||
| sarif_file: markdownlint-cli2-sarif.sarif | ||
| # Optional category for the results | ||
| # Used to differentiate multiple results for one commit | ||
| category: markdownlint | ||
| - name: Build mkdocs site | ||
| run: uv run mkdocs build --strict | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,11 @@ | ||
| # Hallo, Hi, Bonjour :wave: | ||
|
|
||
| I am Matthias, a German living in Montréal, Canada. I am passionate about tech, open source, racquet sports (especially table tennis and squash), and specialty coffee. I like to help others, and so just like with contributing to open source projects, I intend to share information here that are hopefully helpful to someone else. | ||
| I am Matthias, a German living in Montréal, Canada. | ||
| I am passionate about tech, open source, racquet sports (especially table tennis and squash), and specialty coffee. | ||
| I like to help others, and so just like with contributing to open source projects, I intend to share information here that are hopefully helpful to someone else. | ||
|
|
||
| I enjoy building and improving software, in particular building reusable software. With an eye for details and the ability to understand and see the big picture, I am able to provide well-thought-out solutions. It also allows me to quickly understand new/unfamiliar code or concepts and connect the dots when debugging and solving problems. I strive for reusable, clean and maintainable code. I see myself as a generalist, knowing various technologies and the ability to quickly learn new technologies and concepts. | ||
| I enjoy building and improving software, in particular building reusable software. | ||
| With an eye for details and the ability to understand and see the big picture, I am able to provide well-thought-out solutions. | ||
| It also allows me to quickly understand new/unfamiliar code or concepts and connect the dots when debugging and solving problems. | ||
| I strive for reusable, clean and maintainable code. | ||
| I see myself as a generalist, knowing various technologies and the ability to quickly learn new technologies and concepts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| # Projects | ||
|
|
||
| TBD | ||
|
|
||
| This. Is. A. Test. | ||
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.