PropertType: Specify type for custom discriminant values #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use custom discriminant values for enum variants for "PropertType" without specifying the type. This causes it to default to "isize" which on 64bit platforms is big enough to hold the 32bit constants, but causes overflow when isize is 32bit. This issue was uncovered due to build failures on arm for Gentoo Linux as a dependency of ClamAV. Bug: https://bugs.gentoo.org/927214 Signed-off-by: Matt Jolly <[email protected]> Co-authored-by: Steven Newbury <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use custom discriminant values for enum variants for "PropertType" without specifying the type. This causes it to default to "isize" which on 64bit platforms is big enough to hold the 32bit constants, but causes overflow when isize is 32bit.
This issue was uncovered due to build failures on arm for Gentoo Linux as a dependency of ClamAV.
Bug: https://bugs.gentoo.org/927214