Repository navigation
Avoid repeated A/B assignment events from inline variant arrays - #1036
Merged
msitarzewski merged 1 commit intoOct 6, 2026
Conversation
Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
LandingPageHero passes a fresh array on every render. The effect fires again after its own state update and on unrelated rerenders, duplicating assignment analytics. Depend on serialized variant content and reject empty experiments.
This changes one existing agent profile. No generated conversion output or new repository tooling is included.
Verification
bash scripts/lint-agents.sh engineering/engineering-rapid-prototyper.mdpassed.bash scripts/test-convert-outputs.sh --drift=advisorypassed for the complete roster and every supported converter. Expected content manifest drift is advisory; the manifest is unchanged.Native React test-renderer proof covers actual hook/effect scheduling, not statistical experiment validity or browser layout.
New content is coordinated in #917. Related examples/tests are available on request; local proof fixtures are kept outside the upstream source tree.
AI assistance
Prepared with Codex assistance. The patch and native reproduction were reviewed before submission. Signed commit includes the DCO sign-off.