Skip to content

Reject invalid custom page geometry before producing PDF CSS - #1050

Merged
msitarzewski merged 1 commit into
msitarzewski:mainfrom
rudycelekli:campaign/agency-oct5-pdf-geometry
Oct 6, 2026
Merged

msitarzewski merged 1 commit into
msitarzewski:mainfrom
rudycelekli:campaign/agency-oct5-pdf-geometry

Conversation

@rudycelekli

Copy link
Copy Markdown
Contributor

Agent Information

Agent file: engineering/engineering-pdf-engine-architect.md

Motivation

Choosing custom without dimensions silently uses A4; zero, negative and nonfinite dimensions produce invalid CSS and viewport sizes. The actual serialized CSS pixel width must remain positive after rounding; a 0.0001 mm custom width previously passed raw-number checks and emitted 0px. Rounded point dimensions must also remain positive: a 0.0015 mm width previously emitted 0pt even though its CSS pixel width was 0.01px.

Testing

  • Reproduced the original example failure; the corrected example passes the same focused fixture.
  • Changed-agent lint and git diff --check pass.
  • Full scripts/test-convert-outputs.sh --drift=advisory passes all 32 checks over 282 agents and 15 tool formats. Expected content drift is advisory; the generated-output manifest is left to maintainers.

Native extracted example with controlled local inputs; no production system or model-effectiveness claim. No paid API call, real invoice, production data or actual model-effectiveness evaluation was performed.

Candidate listed before publication in #917: #917 (comment). This single-profile correction adds no tooling or generated outputs. AI assistance was used to investigate, implement and test it; the commit is signed and includes DCO sign-off.

Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
@msitarzewski
msitarzewski merged commit 32d5c82 into msitarzewski:main Oct 6, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants