feat: add --division flag for selective agent installation#157
feat: add --division flag for selective agent installation#157kienbui1995 wants to merge 1 commit intomsitarzewski:mainfrom
Conversation
|
Hey @kienbui1995 — love this feature, it's a commonly requested one (see #134). The implementation is clean and backward-compatible. One thing before we merge: # scripts/lib.sh
slugify() { ... }
get_field() { ... }
get_body() { ... }Then both Otherwise this is good to go! |
c4db9fd to
a618867
Compare
|
Rebased on latest main and addressed your review feedback:
Ready for re-review! |
Add --division flag to install.sh for installing agents from specific divisions only. Also extract shared helpers (slugify, get_field, get_body) into scripts/lib.sh per review feedback. Changes: - scripts/lib.sh: new shared helpers sourced by both scripts - scripts/install.sh: add --division flag, active_divisions(), slug_allowed() - scripts/convert.sh: source lib.sh instead of duplicating helpers Closes msitarzewski#134
a618867 to
5c1c444
Compare
|
Hey @kienbui1995 — the lib.sh extraction and --division feature look solid. Two things before we can merge:
Could you rebase and add |
Closes #134
What
Adds a
--divisionflag toinstall.shso users can install agents from specific divisions only, instead of all 120 agents.Usage
How It Works
Test Results
Per-division breakdown (all verified)
Changes
scripts/install.sh(+84 lines)--divisionflag parsing with validationactive_divisions(),slug_allowed()filtering helpers