Open
Conversation
… Manager, Civil Engineering, Network Engineering, ServiceNow Developer) Add new agent markdown files following the existing format and directory conventions: - engineering/engineering-database-engineer.md — DB design, query optimization, migrations, performance tuning - engineering/engineering-network-engineer.md — Network design, security, troubleshooting - engineering/engineering-servicenow-developer.md — ServiceNow platform development, ITSM, automation - specialized/lawyer.md — Legal consultation, contract review, compliance, IP strategy - product/product-pricing-manager.md — Pricing strategy, competitive analysis, margin optimization - specialized/civil-engineering-agent.md — Structural design, project management, construction technology Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Code ReviewIssue 1 — All 6 agent files use non-compliant section headers [confidence: 100]PR #325 adds 6 new agent files, but none of them use the required section headers from CONTRIBUTING.md. The template requires these exact 9 headers:
All 6 files use a stripped-down, non-standard set of headers without emojis or "Your" phrasing. Representative examples from the diff:
Missing sections across all 6 files:
The content quality of these agents is high — the underlying knowledge is solid. The fix is to restructure the headers to match the required format without changing the content. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
engineering/engineering-database-engineer.md) — DB design, query optimization, migrations, performance tuningengineering/engineering-network-engineer.md) — Network architecture, security hardening, troubleshootingengineering/engineering-servicenow-developer.md) — ServiceNow platform development, ITSM, workflow automationspecialized/lawyer.md) — Contract review, compliance, IP strategy, regulatory guidanceproduct/product-pricing-manager.md) — Pricing strategy, competitive analysis, margin optimization, subscription modelsspecialized/civil-engineering-agent.md) — Structural design, project management, construction technologyAll agents follow the existing frontmatter format (name, description, color, emoji, vibe) and content structure (Identity, Core Mission, Deliverables with code/markdown examples, Critical Rules, Communication Style).
Closes #317, Closes #314, Closes #307, Closes #287, Closes #265, Closes #250
Test plan
🤖 Generated with Claude Code