Skip to content

feat: add 6 new agent definitions#325

Open
toukanno wants to merge 1 commit intomsitarzewski:mainfrom
toukanno:feat/new-agents
Open

feat: add 6 new agent definitions#325
toukanno wants to merge 1 commit intomsitarzewski:mainfrom
toukanno:feat/new-agents

Conversation

@toukanno
Copy link
Copy Markdown

Summary

  • Add Database Engineer agent (engineering/engineering-database-engineer.md) — DB design, query optimization, migrations, performance tuning
  • Add Network Engineering Agent (engineering/engineering-network-engineer.md) — Network architecture, security hardening, troubleshooting
  • Add ServiceNow Developer agent (engineering/engineering-servicenow-developer.md) — ServiceNow platform development, ITSM, workflow automation
  • Add Lawyer agent (specialized/lawyer.md) — Contract review, compliance, IP strategy, regulatory guidance
  • Add Pricing Manager agent (product/product-pricing-manager.md) — Pricing strategy, competitive analysis, margin optimization, subscription models
  • Add Civil Engineering Agent (specialized/civil-engineering-agent.md) — Structural design, project management, construction technology

All agents follow the existing frontmatter format (name, description, color, emoji, vibe) and content structure (Identity, Core Mission, Deliverables with code/markdown examples, Critical Rules, Communication Style).

Closes #317, Closes #314, Closes #307, Closes #287, Closes #265, Closes #250

Test plan

  • Verify each agent file has valid YAML frontmatter
  • Confirm file naming convention matches existing agents in each directory
  • Review content quality and consistency with existing agent format
  • Ensure no duplicate agents with overlapping scope

🤖 Generated with Claude Code

… Manager, Civil Engineering, Network Engineering, ServiceNow Developer)

Add new agent markdown files following the existing format and directory conventions:

- engineering/engineering-database-engineer.md — DB design, query optimization, migrations, performance tuning
- engineering/engineering-network-engineer.md — Network design, security, troubleshooting
- engineering/engineering-servicenow-developer.md — ServiceNow platform development, ITSM, automation
- specialized/lawyer.md — Legal consultation, contract review, compliance, IP strategy
- product/product-pricing-manager.md — Pricing strategy, competitive analysis, margin optimization
- specialized/civil-engineering-agent.md — Structural design, project management, construction technology

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@mhc222
Copy link
Copy Markdown

mhc222 commented Mar 30, 2026

Code Review

Issue 1 — All 6 agent files use non-compliant section headers [confidence: 100]

PR #325 adds 6 new agent files, but none of them use the required section headers from CONTRIBUTING.md. The template requires these exact 9 headers:

  1. ## 🧠 Your Identity & Memory
  2. ## 🎯 Your Core Mission
  3. ## 🚨 Critical Rules You Must Follow
  4. ## 📋 Your Technical Deliverables
  5. ## 🔄 Your Workflow Process
  6. ## 💭 Your Communication Style
  7. ## 🔄 Learning & Memory
  8. ## 🎯 Your Success Metrics
  9. ## 🚀 Advanced Capabilities

All 6 files use a stripped-down, non-standard set of headers without emojis or "Your" phrasing. Representative examples from the diff:

File Headers Present
All 4 of the engineering/product/specialized files ## Identity & Memory, ## Core Mission, ## Critical Rules, ## Communication Style
product-pricing-manager.md Custom subsections (## Model Selection, ## Direct Competitors, etc.) instead of standard sections
specialized/civil-engineering-agent.md Custom phase/structural subsections instead of standard sections
specialized/lawyer.md Domain-specific subsections (## Key Terms Summary, ## Critical Issues, etc.) instead of standard sections

scripts/convert.sh uses these exact header strings to split content into tool-specific formats (e.g., OpenClaw SOUL.md vs. AGENTS.md). Mismatched headers mean sections are silently omitted or misrouted during conversion.

Missing sections across all 6 files:

  • ## 🔄 Your Workflow Process — absent in all files
  • ## 🔄 Learning & Memory — absent in all files
  • ## 🎯 Your Success Metrics — absent in all files
  • ## 🚀 Advanced Capabilities — absent in all files
  • ## 📋 Your Technical Deliverables — absent (replaced by inline content in the Core Mission section)

The content quality of these agents is high — the underlying knowledge is solid. The fix is to restructure the headers to match the required format without changing the content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants