Skip to content

dts: msm8974: Add support for Nokia Lumia 930 #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

dts: msm8974: Add support for Nokia Lumia 930 #508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Documentation/devices.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@
- Samsung Galaxy S5 - SM-G900F
- Samsung Galaxy S5 China LTE (Duos) - SM-G9006V/W, SM-G9008V/W, SM-G9009W
- Sony Xperia Z3 - leo
- Nokia Lumia 930 - martini (quirky - see comment in `lk2nd/device/dts/msm8974/msm8974-nokia-martini.dts`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...MNOPQRS...


### lk2nd-msm8226
- ASUS ZenWatch 2 - sparrow
Expand Down
19 changes: 19 additions & 0 deletions lk2nd/device/dts/msm8974/msm8974-nokia-martini.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
// SPDX-License-Identifier: BSD-3-Clause

#include <skeleton64.dtsi>
#include <lk2nd.dtsi>

//this is the cmd used to compile lk1st for Lumia930
// make TOOLCHAIN_PREFIX=arm-none-eabi- DEBUG=1 DEBUG_FBCON=0 LK2ND_BUNDLE_DTB=msm8974-nokia-martini.dtb lk1st-msm8974
//CAUTION: this device is quirky cause its a Windows phone, it needs cat build-lk1st-msm8974/lk_s.elf build-lk1st-msm8974/lk2nd/device/dts/msm8974-nokia-martini.dtb > emmc_appsboot.mbn
//The panel does not work if lk2nds const-splash is disabled which is the case on lk1st so dont expect display support
Comment on lines +6 to +9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer this to be C style comment (/* */) and folded to 80-100 where it makes sense.


/ {
qcom,msm-id = <QCOM_ID_MSM8974 0x96 0x20002 0xb>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated with msm8974-lge-hammerhead.dts

};

&lk2nd {
model = "Nokia Lumia 930";
compatible = "nokia,martini";
lk2nd,match-cmdline = "*Nokia-martini*";
};