Skip to content

arm64: dts: qcom: pmi8950: VADC channel fixes and additions #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 6.16.3/main
Choose a base branch
from
Open

arm64: dts: qcom: pmi8950: VADC channel fixes and additions #235

wants to merge 2 commits into from

Conversation

Smankusors
Copy link

These should addresses issues with VADC channels on the pmi8950.dtsi

  1. Missing VDD and GND channels. I think these channels are using same address as other Qualcomm's PMIC?
  2. Incorrect scaling factors for the USBIN, DCIN, and VCHG_SNS channels

wdyt? If this is okay, I would like to sent it to upstream too

Note

We can read the voltages from /sys/bus/iio/devices/

@Smankusors
arm64: dts: qcom: pmi8950: add missing vadc channels
09910d0 
When booting msm8953-based devices, the following kernel message appears:
[ 13.090800] qcom-spmi-vadc 200f000.spmi:pmic@2:adc@3100: Please define VDD channel

It turns out we can simply copy the channel with the same address from another pmic dtsi.

Signed-off-by: Antony Kurniawan Soemardi <[email protected]>
@Smankusors
arm64: dts: qcom: pmi8950: fix VADC channel scaling factors
58822e6 
Fix USBIN/DCIN pre-scaling from <1 4> to <1 20> and VCHG_SNS from <1 1>
to <1 3>, matching downstream hardware scaling.

Signed-off-by: Antony Kurniawan Soemardi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Smankusors