clang: fix Any linker error with multiple compilers

[filnet]

reverts this change: llvm/llvm-project@95b27b2

fixes the Rust build, see #16847

[filnet]

Please consider merging. New Rust version is dependent on this new version of LLVM.

[lazka]

Can we change it to the new workaround? Or would you prefer to do that later?

[filnet]

Can we change it to the new workaround? Or would you prefer to do that later?

I'll adapt the patch to the new workaround.

[filnet]

C'est parti...

[mati865]

I think this patch shouldn't be merged for LLVM based subsystems but since it's merged already we can keep probably keep it (unless something regress).

[filnet]

I think this patch shouldn't be merged for LLVM based subsystems but since it's merged already we can keep probably keep it (unless something regress).

Not sure I understand but the patch should land upstream sometimes in the future.

EDIT: I the reason is that the change from 0 to 1 will break things, then it should not according to the llvm maintainers.
The 0 or 1 is apparently irrelevant.

[mati865]

Oh, it's straight from the phabricator. Sorry, missed that bit.
So let's just keep an eye on it and see if sticks or gets reverted.

[filnet]

It is not yet merged : https://reviews.llvm.org/D148953

[filnet]

The fix has been merged upstream.

For sake of completeness, an alternative solution mentioned in the fix discussion:

One could stand on the point that if objects from different compilers are linked, the user needs to supply -f[no-]zero-initialized-in-bss to make sure they behave the same.

We should keep that in mind should a similar issue popup.