Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offer to trash like cards on install #7949

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

NBKelly
Copy link
Collaborator

@NBKelly NBKelly commented Feb 6, 2025

Added a little checkbox you can tick for if you want to (have the option to) trash like cards on any ice, server or program install.

This works for the runner side (it's the same timing that you trash programs for MU), and it works for the corp side. I also made it so you can attempt to install something in a server that's too expensive so long as it's possible to trash things from that server to price it down enough, instead of just silently failing which is what we currently do.

There's a video in slack/

Closes #7948
Closes #2054 (woah that's an old issue)
and I think it hits the last one of #6497 (other than ncigs, which is going to go out the window in a few months)

@NoahTheDuke
Copy link
Collaborator

Good idea but change is not the system to track this. I'm not sure how best to track it (I don't remember if game state has access to user-level options), but change is for in-game numbers that can gain or lose value.

@NBKelly NBKelly changed the title offer to trash like cards (ui, runner side) offer to trash like cards on install Feb 7, 2025
@NBKelly NBKelly marked this pull request as ready for review February 7, 2025 01:17
@NBKelly
Copy link
Collaborator Author

NBKelly commented Feb 7, 2025

I also took it out of change and just added a set-property hook in process-actions, which we can later use for other stuff if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants