Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Explicitly set cursor position #2529

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Tests: Explicitly set cursor position #2529

wants to merge 1 commit into from

Commits on Nov 18, 2024

  1. Tests: Explicitly set cursor position 

    Since we updated QScintilla 2.13 -> 2.14 in Fedora 41+,
we see this test failure:

    _____________ test_EditorPane_toggle_comments_handle_crlf_newline ______________
        def test_EditorPane_toggle_comments_handle_crlf_newline():
            """
            Check that stray "\r\n" line endings don't lead to deleting the first
            character of the following line.
            """
            ep = mu.interface.editor.EditorPane(None, "test\r\nline 2\n")
            ep.hasSelectedText = mock.MagicMock(return_value=False)
            ep.toggle_comments()
    >       assert ep.text() == "# test\nline 2\n"
    E       AssertionError: assert 'test\r\nline 2\n' == '# test\nline 2\n'
    E
    E         - # test
    E         ? --
    E         + test
    E         ?     +
    E           line 2
    tests/interface/test_editor.py:940: AssertionError

I've added some debugging prints and realized that getCursorPosition()
returns 2, 0 in this test, while is assumes the cursor is on line 0.

By explicitly calling setCursorPosition() we fix the test and we make it
more clear to the reader.
    @hroncok
    hroncok committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    baa157c View commit details
    Browse the repository at this point in the history