A couple of serial port improvements #2531
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-packard
force-pushed
the
serial-port-patches
branch
3 times, most recently
from
dd2299f
to
f6ce342
Compare
Share list of USB devices and only update that once a second. When updating, measure if the list has changed by comparing the list length, and then looking at each entry's portName, description and serialNumber. If nothing has changed, short-circuit all of the list updating logic. Signed-off-by: Keith Packard <[email protected]>
Allow serial port code to set the baud rate as well as query. Avoid re-setting the baud rate to the current value as QtSerial seems to do two baud rate settings, first to 4Mbaud and then to the target rate in this case. Signed-off-by: Keith Packard <[email protected]>
Use the base baudrate property setter instead of directly calling QtSerial as that avoids re-setting the rate to the current rate which can confusing the target with two baud rate settings. Signed-off-by: Keith Packard <[email protected]>
keith-packard
force-pushed
the
serial-port-patches
branch
from
f6ce342
to
daa93f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series contains two somewhat unrelated changes.