Skip to content
This repository has been archived by the owner on Jul 18, 2020. It is now read-only.

Fix site title outside posts and text selection around pagination #49

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from

Conversation

rudi-c
Copy link

@rudi-c rudi-c commented Jun 30, 2017

  1. The main title would show " - Scribble", because page.title is empty, now it will show just "Scribble"
  2. I made the pagination container ignore pointer events so that when selecting text, the pagination container doesn't confuse the cursor

Text could previously not be selected correctly around the area where
the pagination arrows was located.
@muan
Copy link
Owner

muan commented Jul 6, 2017

2. I made the pagination container ignore pointer events so that when selecting text, the pagination container doesn't confuse the cursor

Would you clarify what you meant by "confuse the cursor"?

@rudi-c
Copy link
Author

rudi-c commented Jul 6, 2017

Sorry, that wasn't very clear. See the gif below. When the cursor passes over the area where the pagination container is located, selection jumps all the way to the bottom until the cursors exits the pagination area.

bug

@matheustavares
Copy link

  1. I made the pagination container ignore pointer events so that when selecting text, the pagination container doesn't confuse the cursor

This is a very nice change :) Previously, links that fall right behind the container also get unclickable. But your PR solves the problem, thanks :) I hope you don't mind, I already applied this commit to my fork (keeping your authorship, of course)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants