-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up popup.css #180
base: master
Are you sure you want to change the base?
Clean up popup.css #180
Conversation
Well, at first I forgot which panels this actually applies to and after a few tries found out it is also the autocomplete, downloads and library panel. Either way, the point of this PR was to remove that 300 lines of code which was specifically made for the pre-70 info panel that had those huge icons and 3 sections. I do agree that things should be separated to files where possible, especially the autocompete and "global" popup styles. What I don't like is the buttons you use on the popups, why not use the full-width iconized ones like Chrome now? |
The new popups look very Chrome-ish, so the majority of the styles are no longer needed in my opinion. The separator lines and "Permissions" heading are also no longer needed as there are only two sections now. I removed the connection security icon as it didn't match the address bar one and doesn't exist in Chrome's page popup.
However, this is a draft pull request as there is still some work to be done: