Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ryanairbee #163

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Ryanairbee #163

wants to merge 3 commits into from

Conversation

penguwin
Copy link
Collaborator

@penguwin penguwin commented Jul 3, 2017

Opening pull request so far, i'll keep an eye of it.

penguwin added 3 commits July 2, 2017 23:22
Ryanairbee doesn't support that much atm. Only fetching flight
infortmation containing flight number, flight depature and arrival
@muesli
Copy link
Owner

muesli commented Jul 5, 2017

That means you don't consider it ready yet?

@penguwin
Copy link
Collaborator Author

penguwin commented Jul 5, 2017

Well one the one hand, the ryanair api library does only offer two more functions at the moment: GetAirportsCityCoordinatesMap and GetAirportsCityIataMap and to be honest I don't think those are 'really' useful. I have no problem to implement them into the hive before we merge the pull request if desired.

On the other hand we should consider merging the major/bigger airlines into one 'flights/airlines' hive in further future. One single hive for the airlines would keep beehives interface clean and simple.
Another upside would be that you'll only have to trigger one action to fetch data from the reqistered airlines and you'll also only have to evaluate one particular event. Then we could sort and evaluate most data inside of beehive and implement additional values into the events (f.e. min_costs or ordering flights per schedule) - for users comfort :)

@muesli
Copy link
Owner

muesli commented Jul 7, 2017

Agreed, a meta flight-search API might be more appealing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants