Starlark #341
Open
Starlark #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muesli
reviewed
Oct 7, 2020
| log.Println("\tExecuting filter:", filter) | ||
| func execFilter(source string, opts map[string]interface{}) bool { | ||
| name := "template" | ||
| if strings.Contains(source, "def main(") { |
There was a problem hiding this comment.
I'm not too happy with this "string magic". Maybe we could introduce proper filter types? I was also pondering having simple bash-scripts as filters, which either return 0 or 1 as a result.
There was a problem hiding this comment.
I'm also not sure if it is a good solution but it requires a selector on the UI side and I'm not ready to dive into Ember. If you're ready to do such adjustments, please, do.
If to talk about a better backend-only solution, I can propose shebangs. In that case, this line will be if strings.HasPrefix(source, "#!/usr/bin/env starlark") , for example.
Bash scripts is a cool and fun idea. I'm sure some will be happy to build grep/sed/awk/perl pipelines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Starlark template filter syntax support. See the included documentation for more information
Motivation
Requirements
Blocked by #340 (contains that PR in the diff)
TODO
The
inputfield for filters in beehive-admin should be changed totextarea. For now, I'm using YAML configuration file from #339 to write starlark filters.