Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new timer widget #66

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

zMoooooritz
Copy link
Contributor

@zMoooooritz zMoooooritz commented Jan 29, 2022

A new widget for our beloved streamdeck

I decided to not properly implement times that exceed 1 hour since the widget would have become to complex for the little space a button offers.
Furthermore I think 1 hour should be sufficient for most timers that are setup at a stremdeck

@muesli in case you think we should display such times please let me know

@norrs norrs mentioned this pull request Feb 3, 2022
norrs and others added 3 commits February 3, 2022 23:03
Support timer configuration by time.Duration formats such as 1h10m15s
etc.
Fixes pause and resume functionality.
@zMoooooritz
Copy link
Contributor Author

zMoooooritz commented Feb 4, 2022

Hey @norrs thank you for the refactoring and improvement of the times formatting for the config files.

I did add in the option 'adaptive' to only display the "required" characters of the timer representation.
The implementation is not optimal but the advanced time formats does not allow for an easier removal of leading "not required" characters.

@norrs
Copy link

norrs commented Feb 5, 2022

@zMoooooritz : Ah, I liked ef337ae 👍 Allows the usage of both worlds.

@muesli Any other changes you find missing? Let us know ❤️

@muesli is free to drop that example.deck before merging. Or if he wants to keep it, we should add the adaptive configuration in the example ( @zMoooooritz )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants